scx_lavd: directly accumulate task's runtimes for consecutive runnings #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 29, 2024 14:49
Let's change the function names of update_stat_for_*() as follow their callers for consistency and less confusion. Signed-off-by: Changwoo Min <changwoo@igalia.com>
Remove runtime_boost using slice_boost_prio. Without slice_boost_prio, the scheduler collects the exact time slice. Signed-off-by: Changwoo Min <changwoo@igalia.com>
When a task runs more than once (running <->stopping) within one runnable-quiescent transition, accumulate runtime of multiple runnings for statistics. This helps to get the task's runtime per schedule when supposing that a huge time slice is given, which is what we want to collect for scheduling decisions. Signed-off-by: Changwoo Min <changwoo@igalia.com>
Change the last_{start/stop/wait/wake}_clk in task_ctx to
last_{running/stopping/quiescent/runnable}_clk, matching with state
transition names. In addition, add comments and reorder fields in
task_ctx for readability.
Signed-off-by: Changwoo Min <changwoo@igalia.com>
Change the calculation of the run_frequence using the wait_period from the last time the task yielded CPU to this time when the task is running. The old implementation measures the time interval between the last stopping and the current running and increases run_freq without reason. Signed-off-by: Changwoo Min <changwoo@igalia.com>
Change the upper bound of ineligible duration (LAVD_ELIGIBLE_TIME_MAX). The updated (2x increased) upper bound reflects the distribution of tasks' eligible_delta_ns better. Signed-off-by: Changwoo Min <changwoo@igalia.com>
htejun
approved these changes
Mar 31, 2024
|
Thank you @htejun for the revirew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop slice_boost_prio's multiplying runtime of task's consecutive runnings. Instead of such approximation, let's directly measure the accumulated run time of consecutive runnings in a runnable<-->quiescent transition. The calculation of run_freq has been updated according to this change. In addition, the upper bound of ineligible duration (LAVD_ELIGIBLE_TIME_MAX) increases to better reflect the actual distribution of tasks' ineligible duration. Finally, the rest commits improves the code for better readability.