scx_rustland_core: separate crate source code from assets #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scx_rustland_core needs to ship both a binary part and a source code part, which will be used to build schedulers based on it. To effectively publish the scx_rustland_core crate on crates.io we need to properly separate the source code assets from the crate's main source code. To achieve this, move the assets into a separate directory and declare them inside a [lib] section in Cargo.toml. This allows to publish the crate on crates.io, providing also a clear separation between source code and assets. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
htejun
approved these changes
Apr 4, 2024
|
I should update scx_utils to do the same thing instead of the manual tar/untar from build.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scx_rustland_core needs to ship both a binary part and a source code part, which will be used to build schedulers based on it.
To effectively publish the scx_rustland_core crate on crates.io we need to properly separate the source code assets from the crate's main source code.
To achieve this, move the assets into a separate directory and declare them inside a [lib] section in Cargo.toml.
This allows to publish the crate on crates.io, providing also a clear separation between source code and assets.