layered: Add ability to match by process name #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people have expressed confusion at this behavior. Let's be a bit more explicit in the documentation. Signed-off-by: David Vernet <void@manifault.com>
htejun
approved these changes
Apr 24, 2024
If a library creates threads, those threads will often have the same name. If two different processes of different priority both use a library, it may be that we want the library's threads in each process to be put into different layers. To support this, let's add the ability to filter not only by task name, but also by process name via the task thread group leader's comm. Tested by creating two executables named "foo" and "bar", which both spawn a bunch of tasks named "exp_worker" that spin until being interrupted. With this config: https://pastebin.com/Uz2phzxQ, the tasks were correctly matched to the expected layers. Signed-off-by: David Vernet <void@manifault.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a library creates threads, those threads will often have the same
name. If two different processes of different priority both use a
library, it may be that we want the library's threads in each process to
be put into different layers.
To support this, let's add the ability to filter not only by task name,
but also by process name via the task thread group leader's comm.
Tested by creating two executables named "foo" and "bar", which both
spawn a bunch of tasks named "exp_worker" that spin until being
interrupted. With this config: https://pastebin.com/QSGwnkDF, the tasks
were correctly matched to the expected layers.