scx_rustland: small updates #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the README.md adding a link to a live demo video of the scheduler. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Now that we can dispatch directly from select_cpu() we can make the code more compact and readable by removing the force_local logic. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Move scaling after tasks are sent to the dispatcher: tasks are dispatched based on the amount of idle CPUs, so checking for any remaining tasks still sitting in the scheduler after dispatch gives a better idea how busy the system is. Moreover, do not scale the time slice based on nr_cpus (otherwise, systems with a large amount of CPUs would rarely get any scaling at all). Instead, apply a scaling factor as a function of how many tasks are still waiting in the scheduler: nr_scheduled / 2. This method scales better as the number of CPUs increases. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
htejun
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small updates to rustland after the API change:
select_cpu()when possible