Set the correct value for sched-ext journald namespace #97
Conversation
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
| # Sets the maximum number of log files that can be stored for each namespace. | ||
| SystemMaxFiles=5 |
There was a problem hiding this comment.
Is this necessary if we set SystemMaxUse above?
There was a problem hiding this comment.
I read in the journal documentation that it is sometimes worth adding, but of course I can remove it. This limits the default value from 100 to 5, which seems to make sense when using this exclusively for debugging one namespace.
There was a problem hiding this comment.
@Decave I'm also wondering if it's better to increase the space limit to 25M because scx sends a lot of logs to journal.
There was a problem hiding this comment.
So, IIUC SystemMaxSize determines the max file size to trigger the rotation and SystemMaxFiles determines how many rotations we want to keep before dropping them.
In that case maybe bump up a little bit the max size and for max files 5 is probably good enough.
There was a problem hiding this comment.
... and I tested this also on Ubuntu, all good.
services/journald@sched-ext.conf
Outdated
| @@ -1,7 +1,9 @@ | |||
| [Journal] | |||
| # Sets the maximum journal size to 10M for each namespace. | |||
There was a problem hiding this comment.
Comment needs to be updated
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
sirlucjan
force-pushed
the
services-fixes
branch
from
a64da68
to
9848ab4
Compare
This pull request fixes an erroneous entry fixing the size of the sched-ext log in journald namespace.
However the logs were saved correctly in a separate space, so the mistake in the name of the directive made it impossible to limit its size.