Add powered-by footer to event list, alternative to #63 #86
Conversation
@@ -12,9 +12,27 @@ | |||
android:layout_width="match_parent" | |||
android:layout_height="match_parent" | |||
app:layoutManager="LinearLayoutManager" | |||
android:layout_marginBottom="20dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with layout inspector and this margin leaves a little bit too much space covered by the footer, can be changed to 24dp safely (I checked), to avoid incorrect proportions of the bottom items (no more events).
tools:context=".framework.eventlist.EventListActivity" | ||
tools:listitem="@layout/schedjoules_list_item_event"/> | ||
|
||
<include layout="@layout/sticky_header_layout"/> | ||
|
||
|
||
<com.schedjoules.eventdiscovery.framework.microfragments.eventdetails.fragments.views.SchedJoulesFooterView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the duplication should be resolved with the footer in the details view, either with layout of its own and include
tag (extra tags can be added to include
), or extracted style, but probably include
is better, imo.
30f1097
to
79b918d
Compare
@lemonboston please review again. Note that I've rebased and squashed the commits, so you should remove your local branch first. |
Why is I think it would be useful to move the common layout definition of
So adding the special properties at the place of include. |
If we use an |
79b918d
to
34ecc96
Compare
@lemonboston please review. We're going to add this to the list for now, but we're certainly going to add some behavior later on.