Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add and edit events #142

Closed
kankanai opened this issue Jan 8, 2024 · 6 comments
Closed

feature: add and edit events #142

kankanai opened this issue Jan 8, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@kankanai
Copy link

kankanai commented Jan 8, 2024

I have already used it. Currently, it is used for display, but there is no new function. If it is supported, it would be great, such as right clicking on the interface to create or edit an existing schedule

@kankanai
Copy link
Author

kankanai commented Jan 8, 2024

such as https://github.com/nhn/tui.calendar

@tomosterlund
Copy link
Collaborator

Hi there, thanks for opening this issue!

I definitely plan to build this down the road. For now, you can use the callbacks onEventClick onClickDate and onClickDateTime to achieve a similar thing as in the example you sent. You then of course need to implement the form yourself.

The callbacks are documented here: https://schedule-x.dev/docs/calendar/configuration

@tomosterlund tomosterlund added the enhancement New feature or request label Jan 8, 2024
@tomosterlund tomosterlund changed the title hope for add and edit Add and edit events Jan 8, 2024
@tomosterlund tomosterlund changed the title Add and edit events feature: add and edit events Jan 8, 2024
@Artenio
Copy link
Contributor

Artenio commented Jan 9, 2024

Event management is adeptly handled in the current system. However, the integration of a universal "event editor form" poses challenges due to varying use-cases. Each event might require differing levels of detail depending on its specific context. In light of this, customizing forms to suit individual use-cases might be more practical than attempting a one-size-fits-all solution.

The maybe-correct approach involves manually creating your own form and handling the form submission to facilitate new event creation. This means designing a custom form tailored to your specific use-case and then managing the submission process, which interacts with the Schedule-X Calendar Events functionalities.

Alternatively, if there's a preference to incorporate these features directly within the calendar, bypassing external elements, new handlers can be created. These would include callbacks like onEventClick, onClickDate, and onClickDateTime, as suggested by @tomosterlund.

@m0tay
Copy link

m0tay commented Mar 13, 2024

@tomosterlund do the callbacks fire when on mobile? I've tried on chrome devtools, and it seem to not fire. Am I doing somehting wrong?

@aonghas
Copy link

aonghas commented Apr 8, 2024

Also the onClickDateTime seems to fire on mouseup rather than mousedown, so if I wanted to implement a click and drag create new event gesture (as seen on many mobile apps/Google Calendar etc) I don't know if this is possible with the current callback events?

eg. Google calendar
Screen Recording 2024-04-08 at 13 19 18

@tomosterlund
Copy link
Collaborator

@aonghas and @m0tay thanks for reporting your issues. That is in general very helpful. However, please create separate issues when it doesn't directly relate to the exact issue of the OP.

@kankanai regarding this feature request: I've decided to build this feature as a first feature of the premium offering of Schedule-X, meaning I won't build it here in the open sourced repo. Thanks for taking the time to suggest the feature though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants