Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gym to gymnasium and cleaning some imports #10

Closed
mikelitu opened this issue Oct 18, 2023 · 3 comments · Fixed by #11
Closed

Updating gym to gymnasium and cleaning some imports #10

mikelitu opened this issue Oct 18, 2023 · 3 comments · Fixed by #11
Labels
enhancement New feature or request

Comments

@mikelitu
Copy link
Contributor

Hello,

I am working a lot with Sofa in the last few years for my PhD and I have found this repository as @ScheiklP mentioned one code snapshot from it when I was struggling with a grasping simulation. I have to say that this repository is really impressive and I would be really interested to use some of the environments to train some DNN for my PhD and add some extra functionalities along with my work.

However, I came across some problem when trying to install the python package on my computer. I found the error was coming from the Gym package. As I could read at the official repository from OpenAI about Gym, they stopped maintainance on this repository on 2021. The development was moved to Gymnasium and now the recommended form of use is import gymnasium as gym. I think it will be good for new users to have this updated on the main branch. Do you want me to submit a pull request with the necessary changes?

Regards,
Mikel

@ScheiklP
Copy link
Owner

Hi @mikelitu,
thanks a lot for your kind words! :)

I actually have a local branch where I already updated to gymnasium.
I just did not have the time yet to properly review and push it.

I will try to do that in the coming weeks and would be very grateful, if you could review the PR. Would you be interested in that?

Cheers,
Paul

@mikelitu
Copy link
Contributor Author

Hi @ScheiklP,

Thank you for the fast respond. Sure, happy to review the PR once you are done with it.

Best,
Mikel

@ScheiklP ScheiklP added the enhancement New feature or request label Oct 18, 2023
@ScheiklP ScheiklP linked a pull request Oct 18, 2023 that will close this issue
@ScheiklP
Copy link
Owner

Hi @mikelitu,
from a first check, that went easier than expected.
Could you head over to the PR and give it a test drive?

Cheers,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants