Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some values / options enclosed by single quotes should be escaped #97

Open
eihigh opened this issue May 26, 2020 · 0 comments · May be fixed by #98
Open

Some values / options enclosed by single quotes should be escaped #97

eihigh opened this issue May 26, 2020 · 0 comments · May be fixed by #98

Comments

@eihigh
Copy link
Contributor

eihigh commented May 26, 2020

I found the bug as the title suggests. Some values such as comments, default values should be escaped.

Parsing

create table hoge (id bigint comment 'hoge\'s comment');

should be:

 CREATE TABLE `hoge` (
-`id` BIGINT (20) DEFAULT NULL COMMENT 'hoge's comment'
+`id` BIGINT (20) DEFAULT NULL COMMENT 'hoge\'s comment'
 )

I will make a pull request to fix this issue.

eihigh added a commit to eihigh/schemalex that referenced this issue May 26, 2020
@eihigh eihigh linked a pull request May 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant