Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all RDF comments that did not finish with a punctuation. #3349

Merged
merged 1 commit into from Jul 19, 2023
Merged

Fixed all RDF comments that did not finish with a punctuation. #3349

merged 1 commit into from Jul 19, 2023

Conversation

MatthiasWiesmann
Copy link
Contributor

  • Relaxed the validation logic to accept question marks and closing parenthesis.
  • Made test a real, i.e. it does not expect to fail.
  • Improved the error reporting so from a failure you know which term violate the rule.
  • Added test comment/documentation for nicer display in the test output.

@MatthiasWiesmann
Fixed all RDF comments that did not finish with a punctuation.
c6e51cf 
* Relaxed the validation logic to accept question marks and closing parenthesis.
* Made test a real, i.e. it does not expect to fail.
* Improved the error reporting so from a failure you know which term violate the rule.
* Added test comment/documentation for nicer display in the test output.
@RichardWallis RichardWallis merged commit a3abb29 into schemaorg:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatthiasWiesmann @RichardWallis