-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show multiple types (e.g. enhance h1 (breadcrumb) so that it shows all parent types) #78
Comments
I have an enhancement that handles this - Danbri and I are discussing how we get it into the code ~Richard
|
Merging in the entry at https://www.w3.org/2011/webschema/track/issues/20 Originally raised by Jason Ronallo,
|
I think this is important to get into sdo-gozer. Multiple types is not widely understood and it does not help when we are not clear when it occurs in Schema.org vocabulary documentation itself. |
+1 |
1 similar comment
+1 |
Didn't get to this due to major (and incomplete) code reorg, but will need to be getting to this soon. |
OK. I agree that it will be helpful when it can happen. |
→ possible solution in #567 |
Fixed in #567 - thanks @Dataliberate :) |
For review see http://sdo-ganymede.appspot.com/LocalBusiness and below |
Looks good. Note that the "X" for closing the extension links to http://appspot.com/ on the development server. I assume that in the live system, it would get you to http://schema.org/ and that the heuristic for generating that URI fails for appspot.com deployments. |
@mfhepp yeah I'm overhauling all that before we launch any actual extensions. AppEngine gets confused about host names too, e.g. if you serve as webschemas.org it tells you it was webschemas.appspot.com; throw subdomains into the mix and things get tangled quickly. That was why I backed off and made sure we could push some things out into jinja2 templates for maintainability. |
The machine readable https://schema.org/docs/tree.jsonld tree structure showing all schema.org classes has not been updated to show multiple inheritance. I've raised the issue #1679 to address this issue. |
@RehanSaeed yes - that was a pragmatic decision I made when building the tree representation. Perhaps in the future we might do something like give each type an annotation indicating its primary/dominant supertype, but for now the code simply picks one supertype so that we get a clean tree structure with no duplication. I'll respond also in #1679. |
Before I realized that types can have several parents, I was really confused why LocalBusiness shows me sometimes the breadcrumb "Thing > Place > LocalBusiness" and sometimes "Thing > Organization > LocalBusiness".
I think it would be nice to represent this fact also in the breadcrumb on top of the page (and not only indirectly in the property table).
A simple solution: Show one breadcrumb line per parent, sorted alphabetically.
This (or a more beautiful solution) has also the benefit that the
tbody
elements won’t change their order (depending on which breadcrumb you happen to get).The text was updated successfully, but these errors were encountered: