Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -template parameter. #18

Merged
merged 5 commits into from Dec 30, 2016
Merged

added -template parameter. #18

merged 5 commits into from Dec 30, 2016

Conversation

ismailsimsek
Copy link
Collaborator

@ismailsimsek ismailsimsek commented Nov 13, 2016

adds -template parameter. if not provided uses "main/resources/layout/" by default

@rafalkasa
Copy link
Member

Hi @ismailsimsek

Thank you for your contribution. I will review your PR and merge with current version.
I have plan to release new SchemeSpy in this month, and finalise all work that I have been done.

Ismail Simsek added 4 commits November 14, 2016 18:49
Conflicts:
	src/main/java/org/schemaspy/view/HtmlAnomaliesPage.java
	src/main/java/org/schemaspy/view/HtmlColumnsPage.java
	src/main/java/org/schemaspy/view/HtmlComponentPage.java
	src/main/java/org/schemaspy/view/HtmlConstraintsPage.java
	src/main/java/org/schemaspy/view/HtmlMainIndexPage.java
	src/main/java/org/schemaspy/view/HtmlOrphansPage.java
	src/main/java/org/schemaspy/view/HtmlRelationshipsPage.java
	src/main/java/org/schemaspy/view/HtmlTablePage.java
	src/main/java/org/schemaspy/view/MustacheWriter.java
@ismailsimsek
Copy link
Collaborator Author

updated conflict files, now its working with -template parameter.

@rafalkasa rafalkasa self-requested a review December 20, 2016 19:34
@rafalkasa rafalkasa added this to the 6.0.0-beta2 milestone Dec 20, 2016
@ismailsimsek ismailsimsek deleted the templateparametter branch December 22, 2016 08:39
@ismailsimsek ismailsimsek restored the templateparametter branch December 22, 2016 10:49
@ismailsimsek
Copy link
Collaborator Author

ismailsimsek commented Dec 22, 2016

Reopen. closed by mistake.

@ismailsimsek ismailsimsek reopened this Dec 22, 2016
Copy link
Member

@rafalkasa rafalkasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-template parameter work excellent already tested by myself everything work as should

@rafalkasa rafalkasa merged commit 50cff78 into schemaspy:master Dec 30, 2016
@rafalkasa
Copy link
Member

Hi @ismailsimsek

I don't know what I'm doing incorrect that yours merged PR are not available as contribution.
I would like to see everything your work as contributor to the project.

Could you help some how ? Maybe can you crate small change and we will verify how we should creating PR to be present as contribution ?

Based on this I will prepare contribution documentation to the project.

Thank you in advance

rafalkasa pushed a commit that referenced this pull request Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants