Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas/json/problem-object-rfc9457.json could specify additionalProperties=true #3454

Closed
rkovarik opened this issue Dec 18, 2023 · 0 comments
Labels
Issue-Bug Report errors or unexpected behavior (auto-generated by issue forms)

Comments

@rkovarik
Copy link
Contributor

Area with issue?

JSON Schema

✔️ Expected Behavior

As suggested in verified errata for RFC 9457:
...it would have been nice to have "additionalProperties": true explicitly stated.

❌ Actual Behavior

Some implementations of validators default additionalProperties to null / empty schema.
While we might say it's wrong implementation of the validators, due to compatibility with their current impls, we should not expect this to be fixed.

YAML or JSON file that does not work.

{
    "type": "https://example.com/probs/out-of-credit",
    "title": "You do not have enough credit.",
    "detail": "Your current balance is 30, but that costs 50.",
    "instance": "/account/12345/msgs/abc",
    "balance": 30,
    "accounts": ["/account/12345",
                 "/account/67890"]
}

IDE or code editor.

None

Are you making a PR for this?

Yes, I will create a PR.

@rkovarik rkovarik added the Issue-Bug Report errors or unexpected behavior (auto-generated by issue forms) label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Report errors or unexpected behavior (auto-generated by issue forms)
Projects
None yet
Development

No branches or pull requests

1 participant