Skip to content

Commit

Permalink
test: Fix flaky test_replay test
Browse files Browse the repository at this point in the history
Path should be properly quoted as well
  • Loading branch information
Stranger6667 committed Oct 3, 2020
1 parent 5170357 commit 32e506f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions test/cli/test_cassettes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import base64
from urllib.parse import parse_qsl, urlencode, urlparse, urlunparse
from urllib.parse import parse_qsl, quote_plus, unquote_plus, urlencode, urlparse, urlunparse

import pytest
import requests
Expand Down Expand Up @@ -181,8 +181,9 @@ async def test_replay(openapi_version, cli, schema_url, app, reset_app, cassette
assert request.method == serialized["method"]
parsed = urlparse(str(request.url))
encoded_query = urlencode(parse_qsl(parsed.query, keep_blank_values=True))
url = urlunparse((parsed.scheme, parsed.netloc, parsed.path, parsed.params, encoded_query, parsed.fragment))
assert url == serialized["uri"]
encoded_path = quote_plus(unquote_plus(parsed.path), "/")
url = urlunparse((parsed.scheme, parsed.netloc, encoded_path, parsed.params, encoded_query, parsed.fragment))
assert url == serialized["uri"], request.url
content = await request.read()
assert content == base64.b64decode(serialized["body"]["base64_string"])
compare_headers(request, serialized["headers"])
Expand Down

0 comments on commit 32e506f

Please sign in to comment.