Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow selecting Type as strategy for graphql schemas #1982

Closed
devkral opened this issue Jan 23, 2024 · 2 comments · Fixed by #1985
Closed

[FEATURE] allow selecting Type as strategy for graphql schemas #1982

devkral opened this issue Jan 23, 2024 · 2 comments · Fixed by #1985
Assignees
Labels
Priority: High Important but not urgent Type: Feature New functionalities or enhancements UX: Usability Enhances user experience

Comments

@devkral
Copy link
Contributor

devkral commented Jan 23, 2024

Thanks for the great improvements to the graphql schemas. I have a little suggestion how to select the operation:

Would it be possible to subclass the dict used for graphql_schema["Operation"] and provide a as_strategy method?

This would allow intuitively selecting an operation and test all fields.

Example:

graphql_schema["Query"].as_strategy()

This shortcut would maybe be nice for openapi too and could allow feature parity with the existing @parameterize decorator.

Further thought: would it also be possible to implement an as_strategy method directly on a schema (to test everything without selecting)?

@devkral devkral added Status: Needs Triage Requires initial assessment to categorize and prioritize Type: Feature New functionalities or enhancements labels Jan 23, 2024
@Stranger6667
Copy link
Member

Great idea! On it

@Stranger6667 Stranger6667 added Priority: High Important but not urgent UX: Usability Enhances user experience and removed Status: Needs Triage Requires initial assessment to categorize and prioritize labels Jan 23, 2024
@Stranger6667
Copy link
Member

Further thought: would it also be possible to implement an as_strategy method directly on a schema (to test everything without selecting)?

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Important but not urgent Type: Feature New functionalities or enhancements UX: Usability Enhances user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants