Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a docker image for CLI #268

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Create a docker image for CLI #268

merged 2 commits into from
Nov 15, 2019

Conversation

svtkachenko
Copy link
Contributor

@svtkachenko svtkachenko commented Nov 14, 2019 •
edited

Closes #268

aexvir
aexvir reviewed Nov 14, 2019
View reviewed changes
.dockerignore Outdated Show resolved Hide resolved
aexvir
aexvir reviewed Nov 14, 2019
View reviewed changes
.dockerignore Outdated Show resolved Hide resolved
aexvir
aexvir reviewed Nov 14, 2019
View reviewed changes
.github/workflows/master_update.yml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: elgohr/Publish-Docker-Github-Action@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never used a GitHub action for this, personally I prefer to make my own job pushing to CI, but this one doesn't look bad. I'd also take advantage of caching, to avoid unnecessary slowdowns.

So... no need to change anything here, LGTM, I just wanted to let you know about this 🙂

aexvir
aexvir reviewed Nov 14, 2019
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@svtkachenko svtkachenko force-pushed the st/docker branch 4 times, most recently from 4175767 to 42fae70 Compare November 14, 2019 15:54
@svtkachenko svtkachenko changed the title [WIP] Create a docker image for CLI Create a docker image for CLI Nov 14, 2019
Stranger6667
Stranger6667 requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@Stranger6667 Stranger6667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, update the README about usage of these images? and also add an entry to the changelog

@Stranger6667 Stranger6667 merged commit 627ff5b into master Nov 15, 2019
@Stranger6667 Stranger6667 mentioned this pull request Nov 15, 2019
Closed
@Stranger6667 Stranger6667 deleted the st/docker branch November 16, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aexvir aexvir aexvir left review comments

@Stranger6667 Stranger6667 Stranger6667 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svtkachenko @Stranger6667 @aexvir