[WIP] Support for in-process WSGI apps testing #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svtkachenko
changed the title
Stranger6667
requested changes
Nov 18, 2019
Stranger6667
previously requested changes
Nov 20, 2019
Stranger6667
force-pushed
the
st/wsgi
branch
2 times, most recently
from
2abca40
to
c1a3446
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 99.92% 99.93% +<.01%
==========================================
Files 22 22
Lines 1385 1536 +151
Branches 222 248 +26
==========================================
+ Hits 1384 1535 +151
Partials 1 1
Continue to review full report at Codecov.
|
Stranger6667
force-pushed
the
st/wsgi
branch
8 times, most recently
from
0b9a095
to
0c64dc6
Compare
Stranger6667
force-pushed
the
st/wsgi
branch
2 times, most recently
from
14e17e4
to
b6a603b
Compare
Stranger6667
force-pushed
the
st/wsgi
branch
from
b6a603b
to
80cd3f3
Compare
Stranger6667
changed the title
Stranger6667
requested changes
Dec 11, 2019
| @@ -60,8 +64,12 @@ def response_schema_conformance(response: requests.Response, result: TestResult) | |||
| schema = definition.get("schema") | |||
| if not schema: | |||
| return | |||
| if isinstance(response, requests.Response): | |||
There was a problem hiding this comment.
Maybe it will be better to provide some kind of abstraction so code in checks will be unified
| if framework == "aiohttp": | ||
| app = _aiohttp.create_app(prepared_endpoints) | ||
| web.run_app(app, port=port) | ||
| elif framework == "flask": |
There was a problem hiding this comment.
It will be nice to test Django as well - maybe in a separate PR
Stranger6667
force-pushed
the
st/wsgi
branch
2 times, most recently
from
fdc556a
to
6dcbf90
Compare
Merged
Stranger6667
force-pushed
the
st/wsgi
branch
from
6dcbf90
to
695f057
Compare
Stranger6667
force-pushed
the
st/wsgi
branch
2 times, most recently
from
6c7880a
to
f248f4d
Compare
Stranger6667
approved these changes
Dec 12, 2019
Stranger6667
force-pushed
the
st/wsgi
branch
3 times, most recently
from
66b44a6
to
c7e3682
Compare
Stranger6667
force-pushed
the
st/wsgi
branch
from
c7e3682
to
ce67335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
TODO:
validate_apptest_server.shAppin the CLI error outputwerkzeug, notrequests- POSTPONEDrequests.SessionwerkzeugclientUnion[requests.Response, WSGIResponse]or some another class that will provide consistent behavior + verify that all check worksfrom_wsgi