Code normalization for Python 3 + general cleanup #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bintoro
force-pushed
the
compat+cleanup
branch
from
8daf485
to
69c492c
Compare
* Add `compat` module as a shared compatibility layer. * Remove `six` dependency. * Switch to Python 3 style by using `str` in place of `unicode`. * Declare `__all__` in modules so as not to export masked builtins.
bintoro
force-pushed
the
compat+cleanup
branch
from
69c492c
to
2c949b0
Compare
bintoro
added a commit
that referenced
this pull request
Feb 20, 2016
Code normalization for Python 3 + general cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits standardizes on Python 3 style and replaces ad-hoc compatibility maneuvers with a shared compatibility module
compat. It is deployed to all modules viafrom .common import *.Changes to string handling:
strnow produces Unicode strings;unicodeis obsolete.unicode_literalsis now enabled;u-prefixes are obsolete.On Python 2, the
__str__()and__repr__()methods onModelandFieldErrorare patched to transparently encode non-ASCII code points.All modules now declare
__all__to prevent globals from leaking onfrom <> import *.The
sixdependency is gone.