Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the title, but I realize this work is actually about multiple things.
to_native
andto_primitive
ofStringType
should behave the same. When I serialize objects with a string field throughjson.dumps
, I don't want to have special logic handlingto_primitive
when the field passed to the model is not a string. Yes, the database should be migrated, but oftentimes it is nice to be able to cast existing objects into strings, and I do expectto_primitive
to give me back astr
onStringType
s by default.seen_excs
set. SinceFieldError
s override__eq__
, Python states that they are subsequently not hashable unless they also implement__hash__
, so I have done so.A side effect of (1) is that
StringTypes
also must handleNone
forto_primitive
, as serializing objects withListType
s andDictType
s containingStringType
s throwConversionError
s when they containNone
.