Skip to content

Commit

Permalink
build: use third_party DEPOT_TOOLS when running lint scripts (electro…
Browse files Browse the repository at this point in the history
…n#34846)

Some folks (especially build_tools users) do not have a version of depot_tools on their path
  • Loading branch information
MarshallOfSound authored and schetle committed Aug 18, 2022
1 parent 4dc7559 commit 061e2d1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions script/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ const ELECTRON_ROOT = path.normalize(path.dirname(__dirname));
const SOURCE_ROOT = path.resolve(ELECTRON_ROOT, '..');
const DEPOT_TOOLS = path.resolve(SOURCE_ROOT, 'third_party', 'depot_tools');

// Augment the PATH for this script so that we can find executables
// in the depot_tools folder even if folks do not have an instance of
// DEPOT_TOOLS in their path already
process.env.PATH = `${process.env.PATH}${path.delimiter}${DEPOT_TOOLS}`;

const IGNORELIST = new Set([
['shell', 'browser', 'resources', 'win', 'resource.h'],
['shell', 'common', 'node_includes.h'],
Expand Down

0 comments on commit 061e2d1

Please sign in to comment.