Return boolean value based on login prompt being shown or not #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xserxses
requested review from
bogdan-niculescu-sch and
pklawikowski-schibsted
pklawikowski-schibsted
approved these changes
Jan 29, 2024
| */ | ||
| @JvmOverloads | ||
| suspend fun requestLoginPrompt( | ||
| context: Context, | ||
| supportFragmentManager: FragmentManager, | ||
| isCancelable: Boolean = true | ||
| ) { | ||
| ) : Boolean { |
There was a problem hiding this comment.
It would be great to have tests for that.
pklawikowski-schibsted
deleted the
xserxses/return-value-from-request-login-prompt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While implementing Simplified Login in News Media, we want to prompt user once per time.
With current API, it's not possible to get feedback on if prompt was shown or not.
This simple PR is changing this adding boolean value on requestLoginPrompt.