Skip to content

Commit

Permalink
feat(middy2): middy v2 version (#40)
Browse files Browse the repository at this point in the history
- updated deps
- stopped breaking the middleware chain
- updated the tests
- bump version to 2.0.0
  • Loading branch information
domeq committed Jul 27, 2021
1 parent 72e3b00 commit eac8b60
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 26 deletions.
2 changes: 0 additions & 2 deletions index.js
Expand Up @@ -40,8 +40,6 @@ const accessLogMiddleware = ({ logger = console, level = 'info', excludeHeaders
response: handler.response,
duration: Math.round(performance.now() - handler.event.requestStart) * 1000000,
});

return handler;
},
});

Expand Down
12 changes: 2 additions & 10 deletions index.test.js
Expand Up @@ -75,11 +75,7 @@ test('Middleware logs on error', async () => {
httpMethod: 'GET',
};

await expect(handler(event, {})).rejects.toEqual(
expect.objectContaining({
error,
})
);
await expect(handler(event, {})).rejects.toEqual(error);

expect(mockLogger.info).toHaveBeenCalledTimes(1);
expect(mockLogger.info.mock.calls[0]).toMatchSnapshot();
Expand Down Expand Up @@ -158,11 +154,7 @@ test('Middleware skips sensitive headers on error', async () => {
httpMethod: 'GET',
};

await expect(handler(event, {})).rejects.toEqual(
expect.objectContaining({
error,
})
);
await expect(handler(event, {})).rejects.toEqual(error);

expect(mockLogger.info).toHaveBeenCalledTimes(1);
expect(mockLogger.info.mock.calls[0]).toMatchSnapshot();
Expand Down
24 changes: 13 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
@@ -1,6 +1,6 @@
{
"name": "@schibsted/middy-access-log",
"version": "0.3.0",
"version": "2.0.0",
"description": "Middy middleware for logging processed requests in an access-log like fashion. Optimised for JSON loggers e.g. Bunyan or Pino.",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -47,7 +47,7 @@
},
"homepage": "https://github.com/schibsted/middy-access-log#readme",
"devDependencies": {
"@middy/core": "^1.4.0",
"@middy/core": "^2.4.3",
"babel-eslint": "^10.1.0",
"eslint": "^7.11.0",
"eslint-config-airbnb-base": "^14.2.0",
Expand All @@ -66,6 +66,6 @@
"ramda": "^0.27.1"
},
"peerDependencies": {
"@middy/core": ">=1.0.0"
"@middy/core": ">=2.0.0"
}
}

0 comments on commit eac8b60

Please sign in to comment.