Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navitia: No enum constant PhysicalMode.RAILSHUTTLE #236

Closed
schildbach opened this issue Oct 14, 2018 · 10 comments
Closed

Navitia: No enum constant PhysicalMode.RAILSHUTTLE #236

schildbach opened this issue Oct 14, 2018 · 10 comments

Comments

@schildbach
Copy link
Owner

Exceptions of this kind are pouring in.

Example trip query: from=stop_area:OIF:SA:59590 to=stop_area:OIF:SA:59675

java.lang.IllegalArgumentException: No enum constant de.schildbach.pte.AbstractNavitiaProvider.PhysicalMode.RAILSHUTTLE
at java.lang.Enum.valueOf(Enum.java:257)
at de.schildbach.pte.AbstractNavitiaProvider$PhysicalMode.valueOf(AbstractNavitiaProvider.java:94)
at de.schildbach.pte.AbstractNavitiaProvider.parseLineProductFromMode(AbstractNavitiaProvider.java:620)
at de.schildbach.pte.AbstractNavitiaProvider.parseLineFromSection(AbstractNavitiaProvider.java:434)
at de.schildbach.pte.AbstractNavitiaProvider.parseLeg(AbstractNavitiaProvider.java:500)
at de.schildbach.pte.AbstractNavitiaProvider.parseQueryTripsResult(AbstractNavitiaProvider.java:583)
at de.schildbach.pte.AbstractNavitiaProvider.queryTrips(AbstractNavitiaProvider.java:996)
@grote
Copy link
Contributor

grote commented Oct 14, 2018

Looks like each Navitia region has its own physical modes that need to be found and mapped properly. Is this ParisProvider?

@schildbach
Copy link
Owner Author

Yes, it's ParisProvider.

I'm not sure about the region-specific modes though. So far, I haven't seen any brand names – which I'm sure would pop up if modes were region specific.

@grote
Copy link
Contributor

grote commented Oct 14, 2018

I've seen ORLYVAL already which is a special airport train to Orly only existing in this API region (and not in FranceNorthWest or BritishColumbia).

@schildbach
Copy link
Owner Author

Ok, that indeed falsifies my assumption. What does Navitia say? Is there an API documentation that could help with interpretation?

@grote
Copy link
Contributor

grote commented Oct 14, 2018

The documentation is here: http://doc.navitia.io/#public-transport-objects

the list can -rarely- be extended

@grote
Copy link
Contributor

grote commented Oct 14, 2018

Maybe @prhod can clarify why there's things like (VAL for Orlyval) being returned as a physical mode while it is not even listed in the official documentation above.

@prhod
Copy link

prhod commented Oct 15, 2018

Hello @grote @schildbach. You're right about a problem in the physical_modes: the fr-idf coverage (for Paris and around) contains this irregular VAL value. To correct it, we've added the RailShuttle physical_mode value some weeks ago, and we will change the VAL to RailShuttle ASAP.
It way take a few weeks to be done.

@grote
Copy link
Contributor

grote commented Oct 15, 2018

Thanks for the info! So I guess we just need to add the RailShuttle for now.

@schildbach
Copy link
Owner Author

Added via 3ffabe1.

At some point we should remove PhysicalMode.VAL.

@grote
Copy link
Contributor

grote commented Nov 20, 2018

There's news" https://groups.google.com/d/msg/navitia/RM0KaWx_auY/YAOt3HnfCAAJ

  • Physical mode "VAL" renamed "RailShuttle"
  • Add of physical mode "SuspendedCableCar"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants