Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix redshift event listener interaction with the session keyword. #171

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

DanCardin
Copy link
Contributor

Fixes #170

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #171 (bf1ab13) into main (a28c490) will increase coverage by 4.02%.
The diff coverage is 95.86%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   82.84%   86.86%   +4.02%     
==========================================
  Files          30       31       +1     
  Lines        1306     1386      +80     
  Branches      187      173      -14     
==========================================
+ Hits         1082     1204     +122     
+ Misses        183      143      -40     
+ Partials       41       39       -2     
Impacted Files Coverage Δ
src/pytest_mock_resources/fixture/credentials.py 100.00% <ø> (ø)
...pytest_mock_resources/patch/redshift/sqlalchemy.py 92.50% <80.00%> (+30.33%) ⬆️
...pytest_mock_resources/fixture/redshift/__init__.py 97.56% <90.00%> (ø)
src/pytest_mock_resources/sqlalchemy.py 92.71% <90.90%> (ø)
src/pytest_mock_resources/fixture/moto.py 95.23% <95.23%> (ø)
src/pytest_mock_resources/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/container/moto.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/base.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/mongo.py 100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DanCardin DanCardin force-pushed the dc/fix-redshift-session-event-listeners branch 4 times, most recently from 9a1dfe6 to 622a078 Compare October 20, 2022 18:19
@DanCardin DanCardin force-pushed the dc/fix-redshift-session-event-listeners branch from 622a078 to bf1ab13 Compare October 20, 2022 18:33
@DanCardin DanCardin marked this pull request as ready for review October 20, 2022 18:54
@DanCardin DanCardin merged commit 088b180 into main Oct 20, 2022
@DanCardin DanCardin deleted the dc/fix-redshift-session-event-listeners branch October 20, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such event 'before_execute' for target '<sqlalchemy.orm.session.Session object ...
2 participants