Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decide on behavior support for multiple redshift statements. #172

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

DanCardin
Copy link
Contributor

The multistatement behavior should not be routed through for text objects (and is then i.e. incompatible with 1.4 + warnings or 2.0). the text of text objects can't be reliably pulled out because of params, and it's not clear that pre-rendering it would be without its own quirks, so the prior fix wasn't ideal.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #172 (a8e039e) into main (a28c490) will increase coverage by 3.73%.
The diff coverage is 97.82%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   82.84%   86.58%   +3.73%     
==========================================
  Files          30       31       +1     
  Lines        1306     1394      +88     
  Branches      187      173      -14     
==========================================
+ Hits         1082     1207     +125     
+ Misses        183      150      -33     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
src/pytest_mock_resources/sqlalchemy.py 92.89% <93.75%> (ø)
src/pytest_mock_resources/fixture/moto.py 95.23% <95.23%> (ø)
src/pytest_mock_resources/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/container/moto.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/credentials.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/base.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/mongo.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/mysql.py 94.11% <100.00%> (ø)
src/pytest_mock_resources/fixture/postgresql.py 94.66% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DanCardin DanCardin force-pushed the dc/redshift-engine-patch-test-fixes branch from 4fe10fc to 90f5669 Compare October 26, 2022 12:11
@DanCardin DanCardin force-pushed the dc/redshift-engine-patch-test-fixes branch from 90f5669 to 270edad Compare October 26, 2022 12:38
@DanCardin DanCardin marked this pull request as ready for review October 26, 2022 14:05
@DanCardin DanCardin force-pushed the dc/redshift-engine-patch-test-fixes branch 4 times, most recently from a02b3ba to 006c8fb Compare October 27, 2022 13:52
@DanCardin DanCardin force-pushed the dc/redshift-engine-patch-test-fixes branch from 006c8fb to a8e039e Compare October 27, 2022 14:17
@DanCardin DanCardin merged commit e9d5f0f into main Oct 27, 2022
@DanCardin DanCardin deleted the dc/redshift-engine-patch-test-fixes branch October 27, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants