Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of it to I8 inside SCHISM #15

Open
platipodium opened this issue Jun 5, 2022 · 4 comments
Open

Change type of it to I8 inside SCHISM #15

platipodium opened this issue Jun 5, 2022 · 4 comments
Assignees
@josephzhang8
Labels
enhancement New feature or request

Comments

@platipodium
Copy link
Member

When calling call schism_step(it) we currently need to provide an INT4 as type of it. In ESMF, this is a long int (INT8), and I would recommend also changing to this type for it in SCHISM.
@platipodium platipodium added the enhancement New feature or request label Jun 5, 2022
@platipodium platipodium mentioned this issue Jun 6, 2022
Closed
@platipodium
Copy link
Member Author

@josephzhang8 I really believe we should allow more than 32k time steps. At dt=200 s, this would only get us as far as 75 days...(something seems off in my calculation ...)

@platipodium platipodium mentioned this issue Aug 31, 2022
Open
@josephzhang8
Copy link
Member

josephzhang8 commented Aug 31, 2022 via email

@platipodium
Copy link
Member Author

Thx for correcting me. Would it hurt to use i8 for compatibility with ESMF advancecount?

@josephzhang8
Copy link
Member

josephzhang8 commented Aug 31, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephzhang8 josephzhang8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@platipodium @josephzhang8