Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new env var IPV6_LOCALIZE to enable auto discovery for IPv6 addresses #110

Merged
merged 1 commit into from
May 22, 2023
Merged

Add new env var IPV6_LOCALIZE to enable auto discovery for IPv6 addresses #110

merged 1 commit into from
May 22, 2023

Conversation

luckman212
Copy link
Contributor

@luckman212 luckman212 commented May 15, 2023 •
edited by schlagmichdoch

fixes #69

This was referenced May 15, 2023
Closed
Closed
@schlagmichdoch schlagmichdoch changed the title fixes for https://github.com/schlagmichdoch/PairDrop/issues/71 fixes for #69 May 16, 2023
@schlagmichdoch schlagmichdoch changed the title fixes for #69 Add new env var IPV6_LOCALIZE to enable auto discovery for IPv6 addresses May 16, 2023
@luckman212 luckman212 force-pushed the luckman212-patch-1 branch 5 times, most recently from 544fcea to 77fe047 Compare May 17, 2023 13:56
schlagmichdoch
schlagmichdoch reviewed May 18, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@luckman212
fixes for schlagmichdoch#69
32e909b 
(squashed, docs updated, IPV6_LOCALIZE input validation)
@luckman212
Copy link
Contributor Author

luckman212 commented May 19, 2023 •
edited

@schlagmichdoch I pushed an update to index.js and the docs. I tested it with various values (some invalid) such as

IPV6_LOCALIZE=4
IPV6_LOCALIZE=0
IPV6_LOCALIZE=999
IPV6_LOCALIZE=-1
IPV6_LOCALIZE=true
IPV6_LOCALIZE=false
IPV6_LOCALIZE=
IPV6_LOCALIZE=''

LGTM but please let me know if this is ok.

@schlagmichdoch schlagmichdoch merged commit c9e1c25 into schlagmichdoch:master May 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlagmichdoch schlagmichdoch schlagmichdoch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug? device discovery not working without manual pairing
2 participants
@luckman212 @schlagmichdoch