Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi Schlamar, I've been hacking on this program a lot, can we discuss merging? #11

Closed
wants to merge 24 commits into from

Conversation

JanKanis
Copy link

I have made a lot of changes:

  • renamed the pip package to latexmake, mainly so I could put my changes on pypi. If you are interested in merging I should probably change it back to latexmk.py.
  • added a number of features, the major one being watching files for changes. Another one is notifications of successful builds and errors through Gnome desktop notifications.
  • I used some python3-isms so the code currently is python3 only. Since this is a stand alone program and not a library I don't consider that a big problem, but it would be possible to make the code python2 compatible again.
  • I've changed the license to GPLv3+, since I prefer my code to be copylefted.

You may not agree with all the changes I have made, so this pull request is mostly intended to discuss if you are interested in merging and what.

My code has an optional dependency on the python inotify package. You can find a working version at http://bitbucket.org/JanKanis/python-inotify.

* converted from optparse to argparse
* make python 3 compatible
* implemented previewer support on Linux
* use hashing to check for .toc equality
* implemented more verbosity options
* implemented --tex-command option
* implemented desktop notification
* some other small changes
Latexmake now supports latexmk.pl's -pvc option in the form of the -w option, to watch files for changes. There are also a number of other minor changes that happened in the course of implementing watching.
…ollWatcher.add accept an (ignored) mask argument
…k.py to latexmake.py in several files and changing the LICENSE file.
- update patterns to hopefully match the entire error message
- try to make the desktop notifications show more of the useful parts of latex errors.
- add preliminary test file
@schlamar
Copy link
Owner

I might think about a merge if you reconsider your license choice. GPL is a no-go for me (a few reasons can be found here: http://lucumr.pocoo.org/2013/7/23/licensing/).

@schlamar
Copy link
Owner

BTW, you are not allowed to relicense my MIT code under GPL. You have to keep my original license note and can only license your new code to GPL. Everything else is license violation!

@JanKanis
Copy link
Author

JanKanis commented Aug 1, 2013

Hi Schlamar,

I am aware of the conditions of the MIT license, if you look at the LICENSE file in my branch you will see that the notice is left intact.

My choice for copyleft is also a principled one. I also had read the article you linked to as it was on hackerne.ws as you likely know. However I don't think it explains why someone or why you in particular would choose a non-copyleft license rather than a copyleft. The article makes a number of statements I agree with (e.g. of people not being aware enough of what the different licenses entail) and a number I do not, but the difference between the two types of licenses comes down to saying "do whatever you want with this code (including making it non free/proprietary)" or saying "do whatever you want with this code, except you cannot make it non-free". The compatibility problem that the article describes could equally well be solved by standardizing on MIT as on GPL3+.

What I am genuinely interested in is why you choose to license your code under a "do whatever you want, including making it non-free or proprietary" license.

@JanKanis
Copy link
Author

JanKanis commented Aug 1, 2013

Part of the reason I decided to license my code under my own license is that this project seemed a bit dead when I forked it. I might consider relicensing, but I would need to know what your plans are with this program. Can you tell me something about why you created it and if you still use it regularly and if you think you will be doing so in the future?

@schlamar
Copy link
Owner

schlamar commented Aug 2, 2013

I have another link for you regarding licenses: http://giovanni.bajo.it/post/56510184181/is-gpl-still-relevant

About your other question. You are right, it is kind of dead as my student times are past and I'm seldom hacking LaTeX these days. However, it might be revived if I'm going to make a PhD but that's not sure. Initially, I created it because the latexmake perl version doesn't support the glossaries packages. But I have lately seen some workarounds on tex.stackexchange.com so I don't know if I would really require it anymore (I'm still using it mostly out of convinience though).
So here is my suggestion: consider the development of latexmk.py as stopped and continue on your fork. If I ever consider reviving it I give you a nudge and we can discuss a merge again.

@schlamar schlamar closed this Aug 2, 2013
@JanKanis
Copy link
Author

JanKanis commented Aug 3, 2013

Very well, then I will consider myself maintainer of this package now. One more thing: could you consider adding me as owner for this package on pypi? That way the pypi package name does not have to change. My fork is currently named 'latexmake', but if my version is going to replace your version there's no reason for the name to change. Apparently there were still 150 downloads of the package last month so there are people using this, no need to bother them with changing their package. You can add package owners in the pypi web interface. My pypi username is also JanKanis.

@schlamar
Copy link
Owner

schlamar commented Aug 3, 2013

@JanKanis Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants