Repository navigation
Conversation
Contributor
|
Hi, thanks for your effort! I'm sure this will be interesting for many people :) I have taken a look now and tried writing a basic bot with your framework. The basic setup looks good to me and it seems to work quite well, but I still have a few comments/questions/suggestions:
Related Pull Request for the website: schlangenprogrammiernacht/website#22 |
…ement The framework files are no longer moved into the /spndata directory This also means framework data is not backed up along with every usercode iteration
This is used to generate the documentation for the players.
|
When starting a bot, this build output gets logged: I'm unsure if pylint is very useful here at all. |
|
those superflous pylint warnings should either get fixed or silenced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "build container" for python bots. Complete with abstraction api