enable checkImplicitMixed

schlndh · Apr 19, 2024 · 462a845 · 462a845
1 parent 776090d
commit 462a845
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -11,8 +11,7 @@ parameters:
 		- src
 		- tests
 	treatPhpDocTypesAsCertain: false
-	# TODO: enable this
-	# checkImplicitMixed: true
+	checkImplicitMixed: true
 	excludePaths:
 		- tests/*/data/*
 	exceptions:

diff --git a/tests/Analyser/AnalyserTest.php b/tests/Analyser/AnalyserTest.php
@@ -1366,6 +1366,7 @@ public function testValid(string $query, array $params = [], array $explicitFiel
 		}
 
 		foreach ($rows as $row) {
+			$this->assertIsArray($row);
 			$this->assertSame($fieldKeys, array_keys($row));
 
 			foreach ($forceNullsForColumns as $col => $mustBeNull) {
@@ -1392,6 +1393,7 @@ public function testValid(string $query, array $params = [], array $explicitFiel
 				}
 
 				$parsedDateTime = false;
+				$this->assertIsString($val);
 
 				foreach (['Y-m-d H:i:s', 'Y-m-d'] as $format) {
 					$parsedDateTime = $parsedDateTime ?: DateTimeImmutable::createFromFormat($format, $val);
@@ -1875,9 +1877,13 @@ public function testValidNullability(string $query, array $params = []): void
 			$rowCount,
 			'Nullability test query has to return at least 1 row, but it did not return any.',
 		);
-		$nullCountsByColumn = array_fill_keys(array_keys($rows[0]), 0);
+		$firstRow = $rows[0];
+		$this->assertIsArray($firstRow);
+		$nullCountsByColumn = array_fill_keys(array_keys($firstRow), 0);
 
 		foreach ($rows as $row) {
+			$this->assertIsArray($row);
+
 			foreach ($row as $col => $value) {
 				if ($value !== null) {
 					continue;