Rubyzip and some other tweaks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry if I'm mistaken regarding the Bones dependency. Happy to revert that commit so this PR is smaller. Also, any reason for the unused |
|
Looks good, I am not sure why the spec directory is there. Feel free to remove it. As you can probably tell I don't use this gem in production anymore. |
|
Cool, thanks @schlu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Gemfile, bundler rake tasks, basic test task. Also removed a dependency on Bones which appeared to be unused (67faef5).
Changed from Zip to RubyZip, as the earlier Zip dependency was breaking things when using Selenium.