Fix when fork used in non-main thread #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt
added a commit
that referenced
this pull request
May 23, 2013
Fix when fork used in non-main thread
|
Thanks for your work. I'll release a new version, as soon as I have time to test this extensively. Released with v0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a process forks from a thread that is not Thread.main, the dynamic variables are not copied to the subprocess, resulting in breakage should anything in the subprocess call structured warnings code, such as use of the overridden Kernel#warn. This is due to the fact that Thread.main in a forked process is inherited from Thread.current in the forking process, and no other threads are copied.
This PR includes a failing test and a fix that uses a singleton class level instance variable to provide the 'main' dynamics Hash rather than relying on Thread.main remaining the same object within forked subprocesses.