Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetResponseForExceptionEvent::getException() is deprecated #241

Closed
gjuric opened this issue Jan 16, 2020 · 2 comments
Closed

GetResponseForExceptionEvent::getException() is deprecated #241

gjuric opened this issue Jan 16, 2020 · 2 comments

Comments

@gjuric
Copy link

gjuric commented Jan 16, 2020

LocaleChoosingListener uses 2 deprecations:

  • GetResponseForExceptionEvent is deprecated since Symfony 4.3, ExceptionEvent should be used
  • GetResponseForExceptionEvent::getException() method is deprecated since Symfony 4.4 and getThrowable() should be used insted

I can submit a PR but before I do that I was wondering what is the policy with BC changes for users of older Symfony versions?
@grizzlylab
Copy link

👍

@toooni toooni mentioned this issue Feb 16, 2021
Merged
@gjuric
Copy link
Author

gjuric commented Mar 10, 2022

This was fixed in #247

@gjuric gjuric closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjuric @grizzlylab