Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discouraged Kernel::VERSION usage #212

Closed
greg0ire opened this issue Feb 8, 2017 · 0 comments
Closed

Discouraged Kernel::VERSION usage #212

greg0ire opened this issue Feb 8, 2017 · 0 comments

Comments

@greg0ire
Copy link
Contributor

greg0ire commented Feb 8, 2017 •
edited

I noticed that Kernel::VERSION is used Legacy. See https://symfony.com/doc/current/setup/bundles.html#updating-your-code-to-support-symfony-2-x-and-3-x-at-the-same-time for the right way to do this. Also, to avoid deprecation notices, the new features should be used as soon as they are available, rather than when they are no longer available. A PR is on its way.
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
bdbc1a3 
Fixes schmittjoh#212
@greg0ire greg0ire mentioned this issue Feb 8, 2017
Merged
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
a50a2fc 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
263ec41 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
fd76a46 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
435c1b8 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 8, 2017
@greg0ire
Avoid reliance on kernel version
951f25a 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 9, 2017
Avoid reliance on kernel version
58ba707 
Fixes schmittjoh#212
greg0ire pushed a commit to greg0ire/JMSPaymentCoreBundle that referenced this issue Feb 9, 2017
Avoid reliance on kernel version
ffd55d1 
Fixes schmittjoh#212
psrpinto pushed a commit that referenced this issue Mar 7, 2017
@psrpinto
Avoid reliance on kernel version
0475288 
Fixes #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greg0ire