Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency symfony/templating ? #799

Closed
kevinpapst opened this issue May 8, 2020 · 4 comments · Fixed by #800
Closed

Missing dependency symfony/templating ? #799

kevinpapst opened this issue May 8, 2020 · 4 comments · Fixed by #800
Assignees
Labels

Comments

@kevinpapst
Copy link

Hi,
I received a bug report stating that a build of my app fails during composer install with

!!  PHP Fatal error:  During class fetch: Uncaught ReflectionException: Class "Symfony\Component\Templating\Helper\Helper" not found while loading "JMS\SerializerBundle\Templating\SerializerHelper". in .../vendor/symfony/config/Resource/ClassExistenceResource.php:181

I cannot reproduce the problem.

But looking at the code it seems that the SerializerHelper extends Symfony\Component\Templating\Helper\Helper which itself is not living in the FrameworkBundle but in the Templating package.

So multiple questions:

  • The templating package is neither mentioned in composer require section nor in suggest, should it be added?
  • Could it happen, because jms_serializer.templating.helper.serializer is registered as service by default?

Do you have any other idea how to solve it without requiring symfony/templating?

@goetas
Copy link
Collaborator

goetas commented May 10, 2020

it seems like a bug.
the feature should be enabled only if the templating package is available

@goetas goetas added the bug label May 10, 2020
@goetas goetas self-assigned this May 10, 2020
@kevinpapst
Copy link
Author

kevinpapst commented May 10, 2020

I wasn't able to reproduce the problem, currently using:

  • Symfony 4.4.7
  • jms/serializer-bundle 3.5.0

What can I do to help?

@goetas
Copy link
Collaborator

goetas commented May 11, 2020

#800 should solve it

@kevinpapst
Copy link
Author

That was quick, I didn't even had a chance to test it before you merged.

Thanks another time for your support @goetas 🎉 awesome work 👍

I'll ask my user if he can give it a try and will let you know if he responds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants