Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler is always loaded if not configured #890

Closed
dannyvw opened this issue May 11, 2022 · 1 comment
Closed

Profiler is always loaded if not configured #890

dannyvw opened this issue May 11, 2022 · 1 comment

Comments

@dannyvw
Copy link
Contributor

dannyvw commented May 11, 2022

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Steps required to reproduce the problem

The profiler configuration is always loaded due invalid configuration. "defaultTrue()" does not accept any parameter. https://github.com/schmittjoh/JMSSerializerBundle/blob/master/DependencyInjection/Configuration.php#L38

Expected Result

  • Default value should be based on kernel.debug value

Actual Result

  • Default value is always true
@scyzoryck
Copy link
Collaborator

Good catch & really detailed explanation! Thanks!

Would you like to create pull request with a fix for this issue?

Best, scyzoryck.

@dannyvw dannyvw mentioned this issue May 11, 2022
Merged
@dannyvw dannyvw closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannyvw @scyzoryck