Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default profiler value #892

Merged
merged 1 commit into from Sep 12, 2022
Merged

Fix default profiler value #892

merged 1 commit into from Sep 12, 2022

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented May 11, 2022

Q A
Bug fix? yes
New feature? no
Doc updated /no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #890
License MIT

scyzoryck
scyzoryck approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@scyzoryck scyzoryck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the fix & tests! @goetas could you take another look, please? :)

@dannyvw dannyvw mentioned this pull request Sep 8, 2022
Closed
@goetas goetas merged commit 408ad72 into schmittjoh:master Sep 12, 2022
@goetas
Copy link
Collaborator

goetas commented Sep 12, 2022

thanks!

@dannyvw dannyvw deleted the profiler branch September 12, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scyzoryck scyzoryck scyzoryck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyvw @goetas @scyzoryck