Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include interface metadata #817

Merged
merged 2 commits into from Mar 21, 2021
Merged

Add option to include interface metadata #817

merged 2 commits into from Mar 21, 2021

Conversation

marein
Copy link
Contributor

@marein marein commented Oct 11, 2020

This pull request brings the same functionality as

SerializerBuilder::create()
    ->includeInterfaceMetadata();

to the bundle configuration. I've only written a test for the happy path. If you're interested in this feature and want me to write more, please let me know.

I hope I didn't miss a pull request or issue where this topic was already discussed.

@marein
Copy link
Contributor Author

marein commented Mar 15, 2021

Tests are failing because master is broken with php 7.2.

There was 1 warning:

1) JMS\SerializerBundle\Tests\Cache\CacheClearerTest::testClear
Cannot stub or mock class or interface "Psr\Cache\CacheItemPoolInterface" which does not exist

@goetas
Copy link
Collaborator

goetas commented Mar 21, 2021

Nice! thanks!

@goetas goetas merged commit 26406fe into schmittjoh:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants