Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 support #830

Merged
merged 2 commits into from Jan 10, 2021
Merged

PHP8 support #830

merged 2 commits into from Jan 10, 2021

Conversation

jacekpl
Copy link
Contributor

@jacekpl jacekpl commented Jan 5, 2021 •
edited

Changes based on #819 with travis config fix.

@Necriso
Copy link

Necriso commented Jan 7, 2021

When will this merged?
We are still waiting for it.

@goetas
Copy link
Collaborator

goetas commented Jan 10, 2021

@jacekpl I think that you've forgot to add the php8 build to the travis matrix

@goetas goetas merged commit 6a0aa33 into schmittjoh:master Jan 10, 2021
@goetas
Copy link
Collaborator

goetas commented Jan 10, 2021

thanks!

@goetas goetas mentioned this pull request Jan 10, 2021
Closed
@simPod
Copy link
Contributor

simPod commented Jan 11, 2021

Cool but it's fair to keep commit co-authorship...

@Necriso
Copy link

Necriso commented Jan 11, 2021 •
edited

Will there be a new version tag?
The last is 3.7.0 from june 2020.

@alexander-schranz
Copy link
Contributor

@goetas any possibility to tag a PHP 8 supported version?

@alexander-schranz alexander-schranz mentioned this pull request Jan 23, 2021
Closed
52 tasks
@alexander-schranz
Copy link
Contributor

@goetas Thx for the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacekpl @Necriso @goetas @simPod @alexander-schranz