add CacheClearer #839
Merged
add CacheClearer #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
requested changes
Mar 7, 2021
There was a problem hiding this comment.
i've released your changes in the metadata package as 2.5.0 (see https://github.com/schmittjoh/metadata/releases/tag/2.5.0)
can you add it as requirement in the composer.json?
|
thank you! |
|
@goetas Is it acceptable that it failed the test with --prefer-lowest? |
|
Hmm, I did not notice that... Ideally it should be fixed... 😔 |
|
@goetas problem in CacheClearerTest. I can rewrite it according to |
| @@ -233,6 +233,11 @@ | |||
| <tag name="jms_serializer.deserialization_visitor" format="xml" /> | |||
| </service> | |||
|
|
|||
| <service id="jms_serializer.cache.cache_clearer" class="JMS\SerializerBundle\Cache\CacheClearer" public="false"> | |||
| <argument type="service" id="jms_serializer.metadata.cache"/> | |||
There was a problem hiding this comment.
I think this is missing on-invalid="null entry, as disabling cache (with cache: none) is broken now.
The constructor should be updated to accept null then. :)
There was a problem hiding this comment.
I have already opened a PR #850., would be nice if you could review it. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works only with schmittjoh/metadata#97