Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types to silence Symfony 6.3 deprecation notices #927

Merged

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 15, 2023

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

Symfony 6.3 added a number of return types to the framework. This PR should cover all the ones that popped up when beta testing an application.

Native types are used in all final/internal classes, doc block annotation used otherwise.

@goetas goetas merged commit a48d2ba into schmittjoh:master May 16, 2023
8 checks passed
@goetas
Copy link
Collaborator

goetas commented May 16, 2023

Thanks

@mbabker mbabker deleted the silence-symfony-6.3-return-type-deprecations branch May 16, 2023 11:19
@ruudk
Copy link
Contributor

ruudk commented May 31, 2023

Thanks for fixing this. Since Symfony 6.3 is released, it would be great to have this fix tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants