Allow @Desc to appear earlier in the file #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2015 16:56
added 9 commits
April 14, 2015 12:16
added 2 commits
April 15, 2016 14:42
* upstream/master: (87 commits) Set Loggers on NodeVisitors at construct time Added types in doc blocks added docblocks, minor changes here and there, removal of unused properties/variables Updated changelog prior release. Update changelog Set xlf as default file format Inverting key and value of a choice type depending of choices_as_values strategy Added tests for Extension, compiler passes, controller and config Fix logger interface calls Symfony 3.0 compat update php-parser to either 1.4.1 or 2.x Changing the default answer to "Tests pass?" to "no" Removed installation instructions for Symfony 2.0.x Prepare for release 1.2.1 getting rid of the twig text extension transchoiceWithDefault on SF2.3 Make sure to require symfony/symfony instead of symfony/framework-bundle remove unused injected container remove unused use statement injected request into controller action ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a PR that allows us to add
@Descearlier on: it now takes the last@Descfound and links it to thetrans.This can be useful for example in the following case:
This does not work with the "old" code but does in my fork.
I added some tests to test for this.