Fix serialization of BackedEnum - annotation without name/value

schmittjoh · Feb 6, 2024 · 91d59c7 · 91d59c7
1 parent c952f9d
commit 91d59c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/doc/reference/annotations.rst b/doc/reference/annotations.rst
@@ -387,8 +387,10 @@ Available Types:
 |                                                            | Examples: array<string, string>,                 |
 |                                                            | array<string, MyNamespace\MyObject>, etc.        |
 +------------------------------------------------------------+--------------------------------------------------+
-| enum<'Color'>                                              | Enum of type Color, use its case names           |
-|                                                            | for serialization and deserialization.           |
+| enum<'Color'>                                              | Enum of type Color, use its case values          |
+|                                                            | for serialization and deserialization            |
+|                                                            | if the enum is a backed enum,                    |
+|                                                            | use its case names if it is not a backed enum.   |
 +------------------------------------------------------------+--------------------------------------------------+
 | enum<'Color', 'name'>                                      | Enum of type Color, use its case names           |
 |                                                            | (as string) for serialization                    |

diff --git a/src/Handler/EnumHandler.php b/src/Handler/EnumHandler.php
@@ -44,7 +44,7 @@ public function serializeEnum(
         array $type,
         SerializationContext $context
     ) {
-        if (isset($type['params'][1]) && 'value' === $type['params'][1]) {
+        if ((isset($type['params'][1]) && 'value' === $type['params'][1]) || (!isset($type['params'][1]) && is_a($enum, \BackedEnum::class, true))) {
             if (!$enum instanceof \BackedEnum) {
                 throw new InvalidMetadataException(sprintf('The type "%s" is not a backed enum, thus you can not use "value" as serialization mode for its value.', get_class($enum)));
             }