Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PSR-7 URIInterface objects #1115

Closed
deviantintegral opened this issue Aug 17, 2019 · 1 comment
Closed

Add support for PSR-7 URIInterface objects #1115

deviantintegral opened this issue Aug 17, 2019 · 1 comment
Labels

Comments

@deviantintegral
Copy link

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes

I've had a second project come up where I've needed to serialize and deserialize URI objects. I split the code out into deviantintegral/jms-serializer-uri-handler, and it's usable as is. You need a concrete implementation to deserialize, and I wasn't sure if adding a dependency on guzzle/psr7 (or Zend Dictaros) would be considered for the core serializer.

Thoughts? Happy to file a PR to bring this in if it makes sense.

@goetas
Copy link
Collaborator

goetas commented Aug 18, 2019

Hi, thanks for your proposal. Unfortunately I can not accept this feature request.

Custom handler for some specific data-types are included only of they are part of PHP and they offer a benefit to a big segment of users.
There are some exceptions for popular projects as libraries as doctrine or symfony, supporting some datatypes for that projects surely brings benefits for a big portion of users.

I think that having a separate repository with that handler is a good idea.

@goetas goetas closed this as completed Aug 18, 2019
@goetas goetas added the RFC label Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants