a workaround so that the edit button has a cursor without using the frag... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the page jumps to top with this fix or is this prevented by the javascript? A CSS solution would be nicer IMHO. |
|
The javascript prevents it jumping as it returns false on the onclick event. I think its fairly standard to always have a href with a hash and just have javascript return false. I will leave that up to you to decide though. |
|
Thanks! |
schmunk42
added a commit
that referenced
this pull request
Oct 25, 2013
a workaround so that the edit button has a cursor without using the frag...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a simple fix so that the edit page shows as a pointer, alternatively this could have been done in css but I had a bit of trouble figuring out the structure of how it all pieces together.