Add test coverage for gzip, fix hanging compilation on error.

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.5.1
+
+* Fix bug where [gzip error would hang compilation](https://github.com/schneidmaster/sitemap-webpack-plugin/pull/8) rather than reporting and continuing
+
 ## 0.5.0
 
 * Add optional [formatter configuration](https://github.com/schneidmaster/sitemap-webpack-plugin/pull/7)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "sitemap-webpack-plugin",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Webpack plugin to generate a sitemap.",
   "main": "lib/index.js",
   "scripts": {

src/index.js

@@ -112,7 +112,6 @@ export default class SitemapWebpackPlugin {
 
       if(sitemap !== null && this.skipGzip !== true) {
         zlib.gzip(sitemap, (err, compressed) => {
-          /* istanbul ignore if */
           if(err) {
             compilation.errors.push(err.stack);
           } else {
@@ -124,8 +123,8 @@ export default class SitemapWebpackPlugin {
                 return Buffer.byteLength(compressed);
               }
             };
-            callback();
           }
+          callback();
         });
       } else {
         callback();

test/gzip.test.js

@@ -0,0 +1,24 @@
+/* global jest describe it expect */
+
+import webpack from 'webpack';
+
+jest.mock('zlib', () => {
+  return {
+    gzip: (input, callback) => {
+      callback({
+        stack: 'a gzip error happened'
+      });
+    }
+  };
+});
+
+describe('Gzip error', () => {
+  it('reports error', (done) => {
+    const webpackConfig = require('./success-cases/basic/webpack.config.js').default;
+
+    webpack(webpackConfig, (_err, output) => {
+      expect(output.compilation.errors[0]).toEqual('a gzip error happened');
+      done();
+    });
+  });
+});