Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sitemap Options #1

Merged
merged 5 commits into from
Dec 6, 2016
Merged

Conversation

codedre
Copy link
Contributor

@codedre codedre commented Nov 21, 2016

Add the 3 optional tags base on sitemap.org schema

Copy link
Owner

@schneidmaster schneidmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! Sorry for the delay in reviewing -- I just got married and was taking some time off. I left a few minor comments but generally looks good. Could you also bump the version number in the package.json to 0.1.1? Thanks!

### Options

* `lastMod` [boolean] default `false`
* `priority` [number] defualt `null`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here -- "defualt" -> "default"


* `lastMod` [boolean] default `false`
* `priority` [number] defualt `null`
* `changeFreq` [string] default `null`, list of applicable values based on [sitemaps.org]('http://www.sitemaps.org/protocol.html')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the single quotes around the sitemaps.org URL for it to be properly linked in Markdown

@codedre
Copy link
Contributor Author

codedre commented Dec 6, 2016

Congratulations on getting married!!!!

@schneidmaster schneidmaster merged commit b30745e into schneidmaster:master Dec 6, 2016
@schneidmaster
Copy link
Owner

Thanks! Changes look good, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants