Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong filename in v1.2.0 Linux archive #24

Closed
drazik opened this issue Feb 10, 2019 · 2 comments
Closed

Wrong filename in v1.2.0 Linux archive #24

drazik opened this issue Feb 10, 2019 · 2 comments

Comments

@drazik
Copy link

drazik commented Feb 10, 2019

I tried to install fnm on my ubuntu, but when I executed the install command (curl https://raw.githubusercontent.com/Schniz/fnm/master/.ci/install.sh | bash) I had the following error:

mv: impossible d'évaluer '/tmp/tmp.Op2bPEFVJX/fnm-linux/fnm': Aucun fichier ou dossier de ce type

My system is in french, but it means that /tmp/tmp.Op2bPEFVJX/fnm-linux/fnm doesn't exist. It is because the bin contained in the fnm-linux.zip archive is not named fnm, but fnm-linux:

ll /tmp/tmp.Op2bPEFVJX/fnm-linux/
total 14M
-rw-r--r-- 1 drazik drazik 14M janv. 30 13:49 fnm-linux

Since the file in the macOS archive is named fnm, I assume this is just a mistake while packing the Linux archive.

I easily worked around this issue by forking the repository and updating .ci/install.sh

-  mv $DOWNLOAD_DIR/$FILENAME/fnm $HOME/.fnm/fnm
+  mv $DOWNLOAD_DIR/$FILENAME/$FILENAME $HOME/.fnm/fnm

But I just wanted to let you know that there is an issue preventing from installing fnm by just running the command in the README on Linux ;)

EDIT: actually I just looked at other release, it seems that this is like this from the beginning.

@drazik drazik changed the title Wrong filename is v1.2.0 Linux archive Wrong filename in v1.2.0 Linux archive Feb 10, 2019
Schniz added a commit that referenced this issue Feb 10, 2019
@Schniz
Copy link
Owner

Schniz commented Feb 10, 2019

whooooooops. totally right. Great catch. Unfortunately, the following won't work:

-  mv $DOWNLOAD_DIR/$FILENAME/fnm $HOME/.fnm/fnm
+  mv $DOWNLOAD_DIR/$FILENAME/$FILENAME $HOME/.fnm/fnm

because on Mac, $FILENAME is fnm-macos. #25 changes the CI script to publish fnm-linux/fnm instead of fnm-linux/fnm-linux. 😄

Schniz added a commit that referenced this issue Feb 10, 2019
@Schniz
Copy link
Owner

Schniz commented Feb 10, 2019

Version 1.2.1 will work on Linuxes too.
Thanks again for opening the issue! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants