Quotation marks need to be escaped in Solr facet queries

[ksclarke]

Current facet link produces something like 39_s:"Smythe,%20William%20"Bill"" (when the thing being faceted has quotes in it).

It should be encoded to something like 39_s:"Smythe,%20William%20%5C"Bill%5C"" (where the quotes are escaped by a backslash).

The first will return zero hits while the second will return the correct number of hits.

[ksclarke]

Oops, think I commented in the wrong place; posting here too:

This did not fix the problem. The " needs to be escaped for Solr as " -- this is different from html encoding

See http://lucene.apache.org/core/3_6_0/queryparsersyntax.html#Escaping%20Special%20Characters for more details

Also, the isset() replaced the !empty() -- there are cases where $current['facet'] is empty but set. isset() breaks but !empty() catches both cases.

[ksclarke]

Oh, sorry... see the isset() !empty() issue is filed on another ticket (which is still open)

[waynegraham]

Need to test to see if mysql_real_escape_string has side effects for this; otherwise a quick preg_replace should work...

[waynegraham]

Looking a bit more, Apache_Solr_Service::escape() may be what is needed.

[erochest]

Apache_Solr_Service::escape seemed to introduce extra back-slashes. I may track this down later.