Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember relay password on receive too #177 #179

Merged
merged 2 commits into from Nov 19, 2019
Merged

Remember relay password on receive too #177 #179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
252475f
Remember relay password on receive too #177
maximbaz Nov 19, 2019
b27b814
Switch to GlobalIsSet
maximbaz Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/cli/cli.go
View file
Open in desktop
Expand Up @@ -334,6 +334,9 @@ func receive(c *cli.Context) (err error) {
if crocOptions.SharedSecret == "" {
crocOptions.SharedSecret = rememberedOptions.SharedSecret
}
if !c.IsSet("pass") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only not sure what's the difference to GlobalIsSet, I saw you used a regular IsSet for the send command, that's why I did the same

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maximbaz. I made a mistake! Both of them should be GlobalIsSet. You can update your PR or I can just do it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

crocOptions.RelayPassword = rememberedOptions.RelayPassword
}
}

if crocOptions.SharedSecret == "" {
Expand Down